Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Preprocessing refactoring #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[WIP] Preprocessing refactoring #2252

wants to merge 7 commits into from

Conversation

NicolasTr
Copy link
Contributor

Fix issue #2238

NicolasTr
NicolasTr reviewed Jul 26, 2013
View reviewed changes
sklearn/preprocessing/tests/test_label.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_transform_selected is in preprocessing.label and is tested with Binarizer from preprocessing.data, is it ok?

@amueller
Copy link
Member

I updated the title, it was a bit misleading ;)

NicolasTr
NicolasTr reviewed Jul 26, 2013
View reviewed changes
sklearn/preprocessing/data.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I split the authors?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When in doubt I would put all authors on all files. Though I have no recollection of doing anything in this module ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's what I did

@NicolasTr
Copy link
Contributor Author

Thanks :-)

@amueller
Copy link
Member

I think I would have git-moved the preprocessing.py to preprocessing/data.py and then do the rest, but I don't think it matters much. we'll lose most of the history anyhow :-/

@NicolasTr NicolasTr mentioned this pull request Jul 26, 2013
Closed
5 tasks
mblondel
mblondel reviewed Jul 26, 2013
View reviewed changes
sklearn/preprocessing/label.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it in data.py.

@amueller
Copy link
Member

did you run pyflake to check for unused imports?

@NicolasTr
Copy link
Contributor Author

Done. But I pulled master and I got a "Merge" commit...

@amueller
Copy link
Member

don't worry about it.
👍 for merge.

@arjoly
Copy link
Member

arjoly commented Jul 26, 2013

Take care of the possible modification due to #2251.

@arjoly
Copy link
Member

arjoly commented Jul 26, 2013

So far, it looks good but I haven't look in detail.
I want to say 👍, when the minor comment is fix.

@amueller
Copy link
Member

merged by rebase. thanks :)

@amueller amueller closed this Jul 26, 2013
@arjoly arjoly mentioned this pull request Jul 26, 2013
Closed
@jakevdp jakevdp mentioned this pull request Jul 26, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasTr @amueller @arjoly @mblondel