CI Fixes Windows 64 wheel builds #22532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to fix the problem. The remaining windows failures are all linked to #22310. |
|
I tried an alternative fix in #22533 that does require pinning the vm image. It works but breaks all the amd64 builds. I guess hyper-v isolation is not available on this hardware ? So I guess your fix is fine for now. But it'll probably be temporary when we start using newer images. |
But we might drop Python 3.8 support by then. |
|
I will put a comment to explain the pinned images. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22530 (hopefully)