MAINT Do not propagate n_jobs as n_threads #22593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`n_jobs` is to be used for joblib tasks but not for the number of threads to use for OpenMP.
It is not needed (yet), hence let's just remove it.
Co-authored-by: Olivier Grisel <[email protected]>
jeremiedbb
reviewed
Feb 23, 2022
thomasjpfan
reviewed
Feb 23, 2022
This reverts commit fb19915. Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
In the other parts of the codebase we usually call _openmp_effective_n_threads and pass it into Cython code through n_threads. In this case, the Cython code is calling _openmp_effective_n_threads itself. In the end, it's the same.
For this PR, I'm okay with removing n_threads.
|
Before merging there is problem with a new warning raised in the sphinx doc. |
ogrisel
reviewed
Feb 24, 2022
jjerphan
added a commit
to jjerphan/scikit-learn
that referenced
this pull request
Feb 24, 2022
Catching up with scikit-learn#22593. Co-authored-by: Olivier Grisel <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 26, 2022
Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up for #22134.
What does this implement/fix? Explain your changes.
n_jobsis to be used for joblib tasks but not for the number of threads to use for OpenMP.Any other comments?
As per our discussion, @ogrisel.