DOC Add abstract methods to _BaseDiscreteNB #22596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
jeremiedbb
reviewed
Feb 24, 2022
jeremiedbb's corrections Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb's corrections Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb's corrections Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb's corrections Co-authored-by: Jérémie du Boisberranger <[email protected]>
jeremiedbb's corrections Co-authored-by: Jérémie du Boisberranger <[email protected]>
thomasjpfan's correction Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
approved these changes
Feb 25, 2022
thomasjpfan's corrections Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan's corrections Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Co-authored-by: avm19 <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
PR #22565 has been split in two. This is the second part.
What does this implement/fix? Explain your changes.
Abstract methods
_countand_update_feature_log_probare added to the abstract class_BaseDiscreteNB, along with a minimal description of what these methods should do. I believe this addition will facilitate understanding and maintenance of the code. Currently, the abstract methods aren't mentioned anywhere in plain English, but they are called, and their effects are expected by concrete methods of the same class.Any other comments?
Edits by maintainers are allowed.