Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX Fixes KBinsDiscretizer for encode=ordinal - #22735

Merged
TomDLT merged 7 commits into
scikit-learn:mainfrom
thomasjpfan:fix_feature_names_out_kbinsdiscretizer
Mar 9, 2022
Merged

FIX Fixes KBinsDiscretizer for encode=ordinal#22735
TomDLT merged 7 commits into
scikit-learn:mainfrom
thomasjpfan:fix_feature_names_out_kbinsdiscretizer

Conversation

@thomasjpfan

Copy link
Copy Markdown
Member

Reference Issues/PRs

Fixes #22731

What does this implement/fix? Explain your changes.

This PR add feature names support to KBinsDiscretizer when encode="ordinal".

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

Comment thread doc/whats_new/v1.1.rst Outdated
Comment thread sklearn/preprocessing/tests/test_discretization.py Outdated
Co-authored-by: Guillaume Lemaitre <[email protected]>
@TomDLT
TomDLT merged commit 36c6c74 into scikit-learn:main Mar 9, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KBinsDiscretizer calling get_feature_names_out only works for encode = "onehot"

3 participants