DOC Rework plot_ard.py example #22747

ArturoAmorQ · 2022-03-10T15:27:56Z

Reference Issues/PRs

Fixes #20740.

What does this implement/fix? Explain your changes.

The example on ARDRegression plot_ard.py stopped working since the release 0.23.
This PR fixes it and reworks the example to:

use notebook style progression
use make_regression to create the synthetic dataset
use heatmap to visualize regression coefficients
include comparison with Bayesian Ridge

Any other comments?

This PR would make the example on BayesianRidge plot_bayesian_ridge.py redundant.
One possibility is to suppress it in favor of this reworked example.

…nto plot_ard_fix

jjerphan

Thank you for the revamp of this example, @ArturoAmorQ.

To me, it is much better than before.

Here are some suggestions. Also, I wanted to suggest some changes to improve the section on ARD but couldn't. You can find them in this commit: jjerphan@ede9eec.

examples/linear_model/plot_ard.py

Co-authored-by: Julien Jerphanion <[email protected]>

ArturoAmorQ · 2022-03-16T14:28:34Z

Thanks for the comments, @jjerphan!

You can find them in this commit: jjerphan@ede9eec.

How do I fetch/implement your commit?

jjerphan · 2022-03-16T16:22:24Z

@ArturoAmorQ: if you give me rights to create PRs to your repo, then I can create a PR for this specific commit.

Alternatively if you add my fork as a remote and fetch its content, you should then be able to cherry-pick the commit.

git remote add jjerphan [email protected]:jjerphan/scikit-learn.git
git fetch jjerphan
git cherry-pick ede9eec

ArturoAmorQ · 2022-03-16T17:05:41Z

@ArturoAmorQ: if you give me rights to create PRs to your repo, then I can create a PR for this specific commit.

Alternatively if you add my fork as a remote and fetch its content, you should then be able to cherry-pick the commit.
git remote add jjerphan [email protected]:jjerphan/scikit-learn.git
git fetch jjerphan
git cherry-pick ede9eec

I did both, in case it's needed in the future. Thanks again!

jjerphan

LGTM. Thank you, @ArturoAmorQ!

glemaitre · 2022-04-06T09:54:38Z

This PR would make the example on BayesianRidge plot_bayesian_ridge.py redundant.
One possibility is to suppress it in favor of this reworked example.

We should remove this example. We only need to create a redirection of this suppressed example to the new one at the following location in the doc conf.py:

https://github.com/scikit-learn/scikit-learn/blob/main/doc/conf.py#L249-L256

examples/linear_model/plot_ard.py

Co-authored-by: Guillaume Lemaitre <[email protected]>

examples/linear_model/plot_ard.py

Co-authored-by: Guillaume Lemaitre <[email protected]>

glemaitre

Otherwise LGTM

examples/linear_model/plot_ard.py

ArturoAmorQ · 2022-04-21T09:43:56Z

Thanks for your time and comments @jjerphan and @glemaitre :)

glemaitre · 2022-04-21T10:18:01Z

Thanks @ArturoAmorQ LGTM

Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>

ArturoAmorQ added 3 commits March 8, 2022 11:36

First draft

9778afe

Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…

714150b

…nto plot_ard_fix

Rework plot_ard example to include comparison with Bayesian Ridge

1d75401

github-actions bot added the Documentation label Mar 10, 2022

Improve format

2521a7b

jjerphan self-requested a review March 11, 2022 09:51

ArturoAmorQ added 2 commits March 14, 2022 11:28

Simplify code

02f5d07

Change descriptive text to subsection style

49f547c

glemaitre self-requested a review March 15, 2022 14:49

jjerphan reviewed Mar 16, 2022

View reviewed changes

ArturoAmorQ and others added 6 commits March 16, 2022 11:33

Apply suggestions from code review

9ed30ca

Co-authored-by: Julien Jerphanion <[email protected]>

Change term weights in favor of coefficients

af4fc6e

Change notation data-target to X-y

5e484e6

Move interpretation after plot to improve notebook-style

17d863c

Improve gaussian intuition of noise

71d127e

Correct ref

d20a71c

jjerphan and others added 2 commits March 16, 2022 17:57

DOC Correct ARD section

6fcd239

Apply suggestions from code review

7a038ec

jjerphan approved these changes Mar 18, 2022

View reviewed changes

glemaitre reviewed Apr 6, 2022

View reviewed changes

ArturoAmorQ and others added 6 commits April 6, 2022 14:45

Apply suggestions from code review

ce92edb

Co-authored-by: Guillaume Lemaitre <[email protected]>

Apply suggestions from code review

8b3c450

Co-authored-by: Guillaume Lemaitre <[email protected]>

Split example into sections and add explanations

f577d98

Fix labels in log likelihood plot

55cd937

Improve descriptions

0ccfcbc

Redirect BayesianRidge example to ARD example

092aa0a

ArturoAmorQ added 3 commits April 6, 2022 17:29

Delete BayesianRidge example

d2a8ca3

Solve conflict

b0c4339

Remove images referencing to removed bayesian ridge example

e02f2fa

glemaitre reviewed Apr 7, 2022

View reviewed changes

ArturoAmorQ and others added 6 commits April 7, 2022 15:28

Apply suggestions from code review

841c6c5

Co-authored-by: Guillaume Lemaitre <[email protected]>

Apply suggestions from code review

4e0df6a

Add extrapolation to polynomial plot

9e4d759

Use Symmetric logarithmic to capture negative values

12bdb8c

Improve explanation

9ee28f8

Add author

9c64c04

glemaitre approved these changes Apr 19, 2022

View reviewed changes

examples/linear_model/plot_ard.py Show resolved Hide resolved

ArturoAmorQ commented Apr 19, 2022

View reviewed changes

examples/linear_model/plot_ard.py Outdated Show resolved Hide resolved

Update examples/linear_model/plot_ard.py

3818b33

ArturoAmorQ requested a review from glemaitre April 21, 2022 09:42

glemaitre merged commit d71bfe1 into scikit-learn:main Apr 21, 2022

ArturoAmorQ deleted the plot_ard_fix branch April 25, 2022 08:32

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022

DOC Rework plot_ard.py example (scikit-learn#22747)

fcae509

Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>

Uh oh!

DOC Rework plot_ard.py example #22747

DOC Rework plot_ard.py example #22747

Uh oh!

Conversation

ArturoAmorQ commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

jjerphan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArturoAmorQ commented Mar 16, 2022

Uh oh!

jjerphan commented Mar 16, 2022

Uh oh!

ArturoAmorQ commented Mar 16, 2022

Uh oh!

jjerphan left a comment

Choose a reason for hiding this comment

Uh oh!

glemaitre commented Apr 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ArturoAmorQ commented Apr 21, 2022

Uh oh!

glemaitre commented Apr 21, 2022

Uh oh!

Uh oh!

ArturoAmorQ commented Mar 10, 2022 •

edited

Loading