Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Blog to top menu bar in /stable (#22737) #22769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

francoisgoupil
Copy link
Member

Co-authored-by: Thomas J. Fan [email protected]

Reference Issues/PRs

Improves #22737.

What does this implement/fix? Explain your changes.

We want the ""Community" menu element to be accessible to as many people as possible.
That is why I suggest we show it on scikit-learn.org/stable and not only in the /dev version of the website.

Any other comments?

I cherry-picked the commit d6984db
and pushed it to the 1.0.X branch.

@francoisgoupil
Copy link
Member Author

I just did a quick fix to avoid a numpydoc pb but the real fix in 'main' is #22287. I don't think it is worth backporting it just for the sake of the documentation.,

@adrinjalali
Copy link
Member

we have failing CI here.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifacts looks good.

The CI failure is unrelated and comes from non pinning dependencies versions. I don't think it should be fixed in this PR. I don't even think it should be fixed at all since it's the 1.0.X branch and we don't intend to make a 1.0.3.

@adrinjalali adrinjalali merged commit 37ac678 into scikit-learn:1.0.X Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants