DOC corrected docstring on make_classification #22797
Conversation
| @@ -154,6 +154,11 @@ def make_classification( | |||
|
|
|||
| y : ndarray of shape (n_samples,) | |||
| The integer labels for class membership of each sample. | |||
|
|
|||
There was a problem hiding this comment.
To fix the linting issues:
| -------- | ||
| make_blobs : Simplified variant. | ||
| make_multilabel_classification : Unrelated generator for multilabel tasks. | ||
| selection benchmark", 2003. |
There was a problem hiding this comment.
Same here regarding linting issues:
| selection benchmark", 2003. | |
| selection benchmark", 2003. |
There was a problem hiding this comment.
Hi, thanks for the review... I corrected the error on _samples_generator.py, but I'm not sure how to proceed with the PR. Do I close it and start all over with a new PR?
There was a problem hiding this comment.
Answering my own question: I think I have to push to my fork, and this will update the PR. In case this is not correct, please let me know. This is my first PR ever, so thank you for your patience.
There was a problem hiding this comment.
That is correct. Pushing to the branch on your fork will update the PR.
|
I think I should have done a pull before the last push. But now I'm not sure if that will fix it. Sorry |
Since many people were working on git remote add upstream [email protected]:scikit-learn/scikit-learn.gitYou can try to fix the merge conflict by running: git fetch upstream
# make sure you are on the `docstring1` branch
git checkout docstring1
# Merge `upstream/main` into your branch.
git merge upstream/mainThere will be a merge conflict you would need to resolve. |
Thank you for showing me the steps to try. I don't know why it is skipping tests now. |
I tested your PR locally and can confirm that |
Reference Issues/PRs
Addresses meta issue #21350
What does this implement/fix? Explain your changes.
Corrected docstring on make_classification
Any other comments?
#pariswimlds