Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ShanDeng123
Copy link
Contributor

@ShanDeng123 ShanDeng123 commented Mar 16, 2022

Reference Issues/PRs

Related to #22572.
See also #11537, #19437
Towards #22396

What does this implement/fix? Explain your changes.

Replaces the depreciating function pytest.warns(None).
test_feature_agglomeration also no longer raises a DeprecationWarning- Assertion to check for no warnings is no longer needed.

Any other comments?

Removed unused pytest import

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ShanDeng123

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Mar 17, 2022
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@ogrisel ogrisel merged commit 0f38376 into scikit-learn:main Mar 17, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants