Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Fixes nav bar by dynamically changing searchbar size #22954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #22737

What does this implement/fix? Explain your changes.

Adding the community link to the navbar not work well for certain screen sizes:

Screen Shot 2022-03-25 at 4 52 54 PM

This PR is a quick fix to adjust the width of the search bar, as the display window changes:

Screen Shot 2022-03-25 at 4 55 39 PM

@jeremiedbb jeremiedbb added frontend Quick Review For PRs that are quick to review labels Mar 26, 2022
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested reducing the window to different sizes and it seems to work fine. The nav bar stays on the same line until windows is too small and then everything goes into a menu.

@lesteve
Copy link
Member

lesteve commented Mar 29, 2022

Seems to work fine indeed, even if slightly magical, merging anyway!

@lesteve lesteve merged commit b61e929 into scikit-learn:main Mar 29, 2022
@jeremiedbb
Copy link
Member

responsive design is not magical :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation frontend Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants