Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that laplacian_kernel passes numpydoc validation #23005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gustavo-ren
Copy link
Contributor

Reference Issues/PRs
Addresses #21350

@jeremiedbb
Copy link
Member

Thanks for the PR @gustavo-ren. I made some suggestions.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels Mar 31, 2022
gustavo-ren and others added 2 commits April 1, 2022 08:42
Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Copy link
Contributor Author

@gustavo-ren gustavo-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestions, thank you!

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gustavo-ren

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 231dd7b into scikit-learn:main Apr 4, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
…learn#23005)

* laplacian_kernel docstring correction on issue scikit-learn#21350

* Update sklearn/metrics/pairwise.py

Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>

* Update sklearn/metrics/pairwise.py

Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>

* Update sklearn/metrics/pairwise.py

Co-authored-by: Jérémie du Boisberranger <[email protected]>

Co-authored-by: Jérémie du Boisberranger <[email protected]>
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
…learn#23005)

* laplacian_kernel docstring correction on issue scikit-learn#21350

* Update sklearn/metrics/pairwise.py

Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>

* Update sklearn/metrics/pairwise.py

Adding sugestiong by jeremiedbb

Co-authored-by: Jérémie du Boisberranger <[email protected]>

* Update sklearn/metrics/pairwise.py

Co-authored-by: Jérémie du Boisberranger <[email protected]>

Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants