MAINT Use check_scalar to validate scalar in: BayesianRidge #23051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Apr 27, 2022
glemaitre
approved these changes
May 17, 2022
|
@thomasjpfan Do you want to make a quick review of this one? |
thomasjpfan
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #21927
What does this implement/fix? Explain your changes.
Adds validation for scalar parameters of BayesianRidge.
Any other comments?
I assumed that for bool-type params,
intvalues 0 and 1 are acceptable. This matches the validation used in other estimators. I'm not sure what the valid ranges of values are for the hyperparameters, so I only validated their type.