FIX Fixes Stacking* HTML repr - #23097
Merged
jeremiedbb merged 9 commits intoApr 19, 2022
Merged
Conversation
thomasjpfan
commented
Apr 10, 2022
| #$id div.sk-label label { | ||
| font-family: monospace; | ||
| font-weight: bold; | ||
| background-color: white; |
Member
Author
There was a problem hiding this comment.
On some browsers this background color hides the dashed line on the top. Removing it is enough to fix it.
Member
Author
|
Here is the rendered stacking example. Placing on 1.1 since HTML is going to be the new default. |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the HTML repr for stacking. To fix it, I needed to rethink how the edges are shown. In summary, this PR moves all the z-index and
position: relativestyles into theserialandparallelselectors.Looking at the stacking example main there is a CSS bug: (There is a line through the center)
main
This PR