FIX: Make compute_sample_weight work on sparse target - #23115
Merged
Conversation
kernc
force-pushed
the
compute_sample_weight+sparse
branch
from
April 12, 2022 00:52
b64ed29 to
d5e07b1
Compare
glemaitre
reviewed
May 5, 2022
| :func:`~sklearn.set_config`. | ||
| :pr:`22856` by `Jérémie du Boisberranger <jeremiedbb>`. | ||
|
|
||
| - |Fix| :func:`utils.class_weight.compute_sample_weight` now works with sparse `y`. |
Member
There was a problem hiding this comment.
Let's move the entry in 1.1.1 that will be the bug release that comes just right after 1.1.0
Member
There was a problem hiding this comment.
@jeremiedbb will maybe move this when preparing the final release.
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
approved these changes
May 5, 2022
glemaitre
reviewed
May 6, 2022
Member
|
CIs are green. Thanks @kernc. Merging. |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
) Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Guillaume Lemaitre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR fixes
compute_sample_weight()to work with sparse arrays, so that the models that takeclass_weight="balanced"don't crash, for example:Sparse targets are frequent in multi-label learning.
Any other comments?
Sparse zeros in target are considered a separate class.