ENH propagate eigen_tol to all eigen solver
#23210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micky774
commented
Apr 24, 2022
thomasjpfan
reviewed
Apr 28, 2022
jeremiedbb
reviewed
May 3, 2022
There was a problem hiding this comment.
I wonder if we really a deprecation cycle. Currently eigen_tol is only used with the arpack solver. "auto" will not change the default value in that case, i.e. 0. So directly changing to "auto" is not really backward incompatible, just if a user relies on default values from the signature of the estimator which we chose to ignore several times in the past.
I agree we can switch to "auto" right away in this PR without deprecation. |
thomasjpfan
reviewed
May 6, 2022
thomasjpfan
reviewed
May 10, 2022
thomasjpfan
reviewed
May 24, 2022
thomasjpfan
approved these changes
May 25, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
…into eigen_tol
|
It seems that we introduce an issue with PyPy: #23520 |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Joan Massich <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #21243
Resolves #11968 (stalled)
What does this implement/fix? Explain your changes.
PR #11968: Propagate the
eigen_tolfor the 'arpack', 'amg', and 'lobpcg' solvers.This PR:
Any other comments?
Follow up PRs to:
"auto"option foreigen_toleigen_tol=0toeigen_tol="auto"