Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that strip_tags passes numpydoc validation #23248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

DOC Ensures that strip_tags passes numpydoc validation #23248

merged 1 commit into from
Apr 29, 2022

Conversation

henrymooresc
Copy link
Contributor

@henrymooresc henrymooresc commented Apr 29, 2022 •
edited
Loading

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Ensures that sklearn.feature_extraction.text.strip_tags passes numpydoc validation.

Changes:

  • Removed sklearn.feature_extraction.text.strip_tags from FUNCTION_DOCSTRING_IGNORE_LIST
  • Added "." to the end of multiple lines
  • Added a Returns section

thomasjpfan
thomasjpfan approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.feature_extraction.text.strip_tags passes numpydoc validation DOC Ensures that strip_tags passes numpydoc validation Apr 29, 2022
@thomasjpfan thomasjpfan merged commit 3578a9f into scikit-learn:main Apr 29, 2022
@henrymooresc henrymooresc deleted the my_feature branch April 29, 2022 18:56
@thomasjpfan thomasjpfan mentioned this pull request May 5, 2022
Closed
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request May 19, 2022
@henrymooresc @glemaitre
DOC Ensures that strip_tags passes numpydoc validation (scikit-learn#…
92f8696 
…23248)
glemaitre pushed a commit that referenced this pull request May 19, 2022
@henrymooresc @glemaitre
DOC Ensures that strip_tags passes numpydoc validation (#23248)
3568622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:feature_extraction No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymooresc @thomasjpfan