DOC correct return type of check_random_state #23320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
May 10, 2022
sklearn/utils/validation.py
Outdated
Comment on lines
1174
to
1175
| ``RandomState`` | ||
| The appropriate ``RandomState`` based on the input. |
There was a problem hiding this comment.
We can link to RandomState object from NumPy and be explicit about the seed parameter:
Suggested change
| ``RandomState`` | |
| The appropriate ``RandomState`` based on the input. | |
| :class:`numpy:numpy.random.RandomState` | |
| The random state object based on `seed` parameter. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
Co-authored-by: Maren Westermann <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Maren Westermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #21350
What does this implement/fix? Explain your changes.
Corrects the return type of the function
check_random_stateinsklearn/utils/validation.py.Any other comments?