Fix OpenML timeout - #23358
Merged
Merged
Conversation
ogrisel
approved these changes
May 13, 2022
ogrisel
left a comment
Member
There was a problem hiding this comment.
LGTM as well. I see no reason why the retry delay should be of the same order as a network timeout. The only purpose of the retry delay is to avoid DOSing a service that is already potentially overloaded via a retry mechanism.
This was probably overlooked during the initial review of the PR that introduced the retry mechanism.
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23357.
I am not sure why we were passing
timeout=delayand I did not find anything in #21901. They are not really the same thing,delayis the time to wait for between two attempts,timeoutis the time to wait to get the data.By not passing timeout, we use the default timeout which is "no timeout" (i.e. "wait for ever") by default. You can always use
socket.setdefaulttimeoutif you want to change it.Side-comment: maybe part of the reason we did not see this before is because OpenML started to do some redirections recently (openml.org -> old.openml.org) and for some datasets, that just happens to go over the timeout of 1s we were using. The timeout
_get_data_info_by_namein the issue OP and in_get_data_featuresin my case.