ENH PolynomialFeatures better handle degree=0 - #23370
Merged
Merged
Conversation
Contributor
Author
|
Hi @adrinjalali , could you help take a look at this PR if you got time? Thank you! |
lorentzenchr
left a comment
Member
There was a problem hiding this comment.
@MaxwellLZH Thanks for working on this issue. Here are some small review comments.
Co-authored-by: Christian Lorentzen <[email protected]>
Co-authored-by: Christian Lorentzen <[email protected]>
lorentzenchr
approved these changes
May 14, 2022
lorentzenchr
left a comment
Member
There was a problem hiding this comment.
LGTM. This PR needs a whatsnew entry for version 1.2.
adrinjalali
approved these changes
May 16, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
May 19, 2022
* raise error for PolynomialFeature when include_bias=False and degree=0 * better error message Co-authored-by: Christian Lorentzen <[email protected]> * use elif Co-authored-by: Christian Lorentzen <[email protected]> * address comments * add whatsnew * fix typo Co-authored-by: Christian Lorentzen <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
May 19, 2022
* raise error for PolynomialFeature when include_bias=False and degree=0 * better error message Co-authored-by: Christian Lorentzen <[email protected]> * use elif Co-authored-by: Christian Lorentzen <[email protected]> * address comments * add whatsnew * fix typo Co-authored-by: Christian Lorentzen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #19551 .
What does this implement/fix? Explain your changes.
This PR makes the following two changes:
degree=0, a ValueError will be raised ifinclude_bias=False, a single constant column will be returned ifinclude_bias=Trueregardless of the input number of featuresdegree=0, include_bias=Trueused to have n+1 columns with n being number of input features, now it outputs 1 column correctly.