[MRG] Fix consistency issue between scorer string and metrics function #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me..had a quick look through code. nice work! |
|
LGTM too. This could be included in 0.14. WDYT @GaelVaroquaux? |
Good with me. Could someone do the cherry-picking? |
ogrisel
added a commit
that referenced
this pull request
Aug 7, 2013
[MRG] Fix consistency issue between scorer string and metrics function
|
Ok merged to master, I am testing the cherry-pick to 0.14.X right now. |
|
nice one! |
|
Pushed to 0.14.X as well! |
|
Good 👍 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix the last consistency issue between scorer and metrics function (#2096).
I finally chose to rename
auc_scoretoroc_auc_score,auc_scorertoroc_auc_scorerto have the most explicit name.
I haven't created an alias since I think that is a bad option.