TST Add test for quasi equality for PairwiseDistancesReduction results
#23490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes before porting implementations toits.
PairwiseDistancesReduction results
|
Could you please add a test to check that |
3 tasks
ogrisel
reviewed
May 30, 2022
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 7, 2022
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 7, 2022
ogrisel
reviewed
Jun 7, 2022
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
approved these changes
Jun 7, 2022
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 8, 2022
jeremiedbb
reviewed
Jun 8, 2022
ogrisel
reviewed
Jun 8, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 8, 2022
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jun 8, 2022
ogrisel
approved these changes
Jun 8, 2022
|
Actually there is now a bunch of |
Co-authored-by: Olivier Grisel <[email protected]>
jeremiedbb
approved these changes
Jun 9, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]>
|
Thanks @jjerphan |
ogrisel
added a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…lts (scikit-learn#23490) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partly extracted from #22590
What does this implement/fix? Explain your changes.
Modify tests to add quasi-equality for 32bit implementations.
This comes by anticipation.
Any other comments?