Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX Fix empty changed files in documentation #23541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2022

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Jun 4, 2022

Reference Issues/PRs

See #23534 (comment).

What does this implement/fix? Explain your changes.

This pull request fixes the empty changed files related to the following error: no merge base. I think that the issue may be easily solved by incrementing the fetch-depth parameter during checkout.

@alfaro96
Copy link
Member Author

alfaro96 commented Jun 4, 2022

@alfaro96 alfaro96 added the Quick Review For PRs that are quick to review label Jun 4, 2022
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alfaro96 and others added 2 commits June 4, 2022 20:19
@thomasjpfan thomasjpfan changed the title [FIX] Fix empty changed files in documentation FIX Fix empty changed files in documentation Jun 5, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! LGTM

@thomasjpfan thomasjpfan merged commit 7d9bc17 into scikit-learn:main Jun 5, 2022
ogrisel added a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants