FIX Ensure correct sklearn.metrics.coverage_error error message for 1D array #23548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haochunchang
commented
Jun 6, 2022
thomasjpfan
reviewed
Jun 7, 2022
jjerphan
approved these changes
Jun 20, 2022
Co-authored-by: Julien Jerphanion <[email protected]>
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
…D array (scikit-learn#23548) * Change input array to ensure_2d=True * Reshape input list to 2D if metric is coverage_error * Add test for error message with 1D array on coverage_error * Modify 1D error message test * Use parametrize to test different 1d arrays * Explain why reshape in test_regression_thresholded_inf_nan_input * Add changelog entry for this fix * Add test comments to sklearn/metrics/tests/test_ranking.py Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…D array (scikit-learn#23548) * Change input array to ensure_2d=True * Reshape input list to 2D if metric is coverage_error * Add test for error message with 1D array on coverage_error * Modify 1D error message test * Use parametrize to test different 1d arrays * Explain why reshape in test_regression_thresholded_inf_nan_input * Add changelog entry for this fix * Add test comments to sklearn/metrics/tests/test_ranking.py Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
…D array (#23548) * Change input array to ensure_2d=True * Reshape input list to 2D if metric is coverage_error * Add test for error message with 1D array on coverage_error * Modify 1D error message test * Use parametrize to test different 1d arrays * Explain why reshape in test_regression_thresholded_inf_nan_input * Add changelog entry for this fix * Add test comments to sklearn/metrics/tests/test_ranking.py Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Julien Jerphanion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #23368
What does this implement/fix? Explain your changes.
check_array(., ensure_2d=False)at the beginning of coverage_error toensure_2d=True.test_regression_thresholded_inf_nan_inputin metrics common test to fix failed tests.Any other comments?
Not sure if adding the "if else" in the common test is elegant. It might adds more cognitive complexity. Hoping for any comment on it.