FIX Adopted more direct dtype restraint in preperation for NEP50
#23644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turning this into a draft to wait on NEP 50 completion and merge into |
|
Now that NEP50 is merged and shipped with NumPy 1.24, I think we can move forward with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
In response to NEP 50
What does this implement/fix? Explain your changes.
Currently when building with the (mostly ready) NEP 50 implementation, the tests fail for
sklearn.linear_model.tests.test_bayes::test_dtype_match. This PR makes some small changes to ensure compliance with NEP 50 style dtypes.Any other comments?