DOC Updated URL for Jake's tutorial link #23703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Reference Issues/PRs** Fixes [scikit-learn#23631](scikit-learn#23631) **What does this implement/fix? Explain your changes.** Fixed broken link [https://newcircle.com/s/post/1152/scikit-learn_machine_learning_in_python](https://newcircle.com/s/post/1152/scikit-learn_machine_learning_in_python) for Jake Vanderplas 75 minutes interactive session in docs/presentations.rst **by replace with** Original Youtube link: [https://www.youtube.com/watch?v=cHZONQ2-x7I](https://www.youtube.com/watch?v=cHZONQ2-x7I) Any other comments? The **scikit-learn tutorial by Jake Vanderplas at PyData NYC 2012**: 45 minutes video link redirects to this youtube video as well. But on further investigation on this webpage [http://vanderplas.com/speaking.html](http://vanderplas.com/speaking.html) in November 2012 section, it seems like the video is not available. Let me know if I should remove that list point, because it seems like the video link is stale.
thomasjpfan
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
I'm okay with linking to the Youtube URL directly. (BTW I see that the current link redirects to https://www.protechtraining.com/blog/post/tutorial-scikit-learn-machine-learning-in-python-402, but I think going directly to youtube is better in this case)
LGTM
|
Merging, thanks a lot! |
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Jul 11, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #23631
What does this implement/fix? Explain your changes.
Fixed broken link https://newcircle.com/s/post/1152/scikit-learn_machine_learning_in_python for Jake Vanderplas 75 minutes interactive session in docs/presentations.rst
by replace with
Original Youtube link: https://www.youtube.com/watch?v=cHZONQ2-x7I
Any other comments?
The scikit-learn tutorial by Jake Vanderplas at PyData NYC 2012: 45 minutes video link redirects to this youtube video as well. But on further investigation on this webpage http://vanderplas.com/speaking.html in November 2012 section, it seems like the video is not available. Let me know if I should remove that list point, because it seems like the video link is stale.