DOC Rework plot_adjusted_for_chance_measures.py example #23708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2022 15:45
ogrisel
reviewed
Jun 29, 2022
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Another batch of comments. Other than that, LGTM! Thanks very much @ArturoAmorQ !
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
reviewed
Jul 20, 2022
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Olivier Grisel <[email protected]>
ogrisel
approved these changes
Jul 20, 2022
added 4 commits
July 20, 2022 14:50
added 2 commits
August 10, 2022 18:19
…nto chance_in_clustering
|
Thanks for making the plots color-blind friendlier. I think we could make those plots even more easy to read by dropping homogeneity and completeness. I think doing the analysis for V-measure is enough and homogeneity and completeness do not bring more information to the narrative. |
…nto chance_in_clustering
|
Thanks for your valuable time, @ogrisel! All your comments have been addressed. |
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
thomasjpfan
approved these changes
Aug 29, 2022
Co-authored-by: Thomas J. Fan <[email protected]>
|
Thanks for your time and comments, @thomasjpfan |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…#23708) Co-authored-by: Olivier Grisel <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #23528.
What does this implement/fix? Explain your changes.
Part of the "Reworking examples" series. As mentioned in this comment, the plot_adjusted_for_chance_measures.py example can benefit from a "tutorialization".
Any other comments?
Side effects: