Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Update sklearn.pipeline.make_union to pass numpydoc validation. #23909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2022
Merged

DOC: Update sklearn.pipeline.make_union to pass numpydoc validation. #23909

merged 5 commits into from
Jul 16, 2022

Conversation

stefmolin
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Ensures sklearn.pipeline.make_union passes numpydoc validation.

Any other comments?

@stefmolin
Copy link
Contributor Author

Ping @adrinjalali

adrinjalali
adrinjalali reviewed Jul 16, 2022
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @stefmolin

glemaitre
glemaitre reviewed Jul 16, 2022
View reviewed changes
glemaitre
glemaitre reviewed Jul 16, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@thomasjpfan thomasjpfan mentioned this pull request Jul 16, 2022
Closed
@glemaitre glemaitre merged commit ecef8cb into scikit-learn:main Jul 16, 2022
@stefmolin stefmolin deleted the doc/pipeline_make_union branch July 16, 2022 16:42
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
@stefmolin @adrinjalali @glemaitre
DOC numpydoc validation for make_union (scikit-learn#23909)
227524a 
Co-authored-by: Adrin Jalali <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre added a commit that referenced this pull request Aug 5, 2022
@stefmolin @adrinjalali @glemaitre
DOC numpydoc validation for make_union (#23909)
d957d4d 
Co-authored-by: Adrin Jalali <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali left review comments

@glemaitre glemaitre glemaitre left review comments

Assignees
No one assigned
Labels
Documentation module:pipeline No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefmolin @adrinjalali @glemaitre