DOC Ensure polynomial_kernel passes numpydoc validation
#23953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add period at the end of summary. - Add description to parameter "X". - Add description to parameter "Y". - Add description to parameter "degree". - Add description to parameter "coef0". - Add description to return value.
- Add period at the end of summary. - Add description to parameter "X". - Add description to parameter "Y". - Add description to parameter "degree". - Add description to parameter "coef0". - Add description to return value.
Micky774
reviewed
Jul 20, 2022
There was a problem hiding this comment.
Hey there @Mathews-Tom, thank you for the PR! I left a comment on how to fix the current failing test, and a few small suggestions regarding wording. Please let me know if you have any questions or concerns.
Co-authored-by: Meekail Zain <[email protected]>
Co-authored-by: Meekail Zain <[email protected]>
Co-authored-by: Meekail Zain <[email protected]>
Co-authored-by: Meekail Zain <[email protected]>
Co-authored-by: Meekail Zain <[email protected]>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 4, 2022
…rn#23953) Co-authored-by: Meekail Zain <[email protected]>
glemaitre
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Meekail Zain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Address #21350
What does this implement/fix? Explain your changes.
sklearn.metrics.pairwise.polynomial_kernelfrom test_doctrings.pyFUNCTION_DOCSTRING_IGNORE_LIST.