MNT Param validation: Uniformize constraints for kernel params #24035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Jul 29, 2022
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM. I am OK with those new constraints allowing support for constant kernels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We(I)'ve not been very consistent for the parameter constraints of the
gamma,coef0anddegreeparameters. They are parameters of kernel based estimators, usually directly passed to the kernel. This PR uniformizes the constraint.Note that degree=0 and gamma=0 lead to constant kernel which is probably not very useful but we keep them for now, at least for backward compat.
cc/ @glemaitre