DOC Updates linear_model.Perceptron regarding t_ #24073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by Sean Atukorala<[email protected]>
thomasjpfan
reviewed
Aug 1, 2022
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I think this impacts all subclasses of BaseSGDRegressor. Can you update the following places as well:
git grep "n_iter_ \* n_samples"
sklearn/linear_model/_passive_aggressive.py: Same as ``(n_iter_ * n_samples)``.
sklearn/linear_model/_passive_aggressive.py: Same as ``(n_iter_ * n_samples)``.
sklearn/linear_model/_stochastic_gradient.py: Same as ``(n_iter_ * n_samples)``.
sklearn/linear_model/_stochastic_gradient.py: Same as ``(n_iter_ * n_samples)``.
sklearn/linear_model/_stochastic_gradient.py: Same as ``(n_iter_ * n_samples)``.….py and _stochastic_gradient.py
jjerphan
approved these changes
Aug 5, 2022
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @ShehanAT.
@thomasjpfan: I think it is fair to merge DOC PRs with only one review from a maintainer.
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the documentation to reflect the changes stated in this issue #23390
scikit-learn/sklearn/linear_model/_perceptron.py
Lines 137 to 139 in 5908ae8
Fixes #23390