Fix Taylor expansion documentation #24122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Aug 5, 2022
Member
jjerphan
left a comment
There was a problem hiding this comment.
LGTM. Thank you, @ravimakhija.
Co-authored-by: Julien Jerphanion <[email protected]>
Contributor
|
Good catch👍 |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
Co-authored-by: Julien Jerphanion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error in the documentation for Gradient Boosting Trees, specifically in the section "1.11.4.5. Mathematical formulation".
In particular, the derivative should be taken with respect to$z$ , not $a$ in the example "Note" in the documentation. This PR should correct this error.
Link: https://scikit-learn.org/stable/modules/ensemble.html