DOC Ensures that load_svmlight_files passes numpydoc validation #24164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Aug 10, 2022
Comment on lines
271
to
272
| https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/multilabel.html | ||
| ). |
There was a problem hiding this comment.
Our character limit is 88, so that ) should fit. Did you get an error here from the tests or a linter?
There was a problem hiding this comment.
Thank you for the reviews! No, I cut the line out of habit for 80 (oops). Let me fix that.
…iles to pass docstring test
3500ebc to
00f8216
Compare
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…it-learn#24164) Co-authored-by: Franck Charras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350