Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensures that dcg_score & roc_curve passes numpydoc validation #24351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

shellyfung
Copy link
Contributor

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Fixed docstring to allow sklearn.metrics._ranking.dcg_score and sklearn.metrics._ranking.roc_curve docstring to pass numpydoc validation.

Any other comments?

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will wait for the CI to complete before merging.

@glemaitre glemaitre merged commit 672ea07 into scikit-learn:main Sep 5, 2022
@shellyfung
Copy link
Contributor Author

LGTM. I will wait for the CI to complete before merging.

thanks

@shellyfung shellyfung deleted the dcg_score branch September 5, 2022 14:08
@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics._ranking passes numpydoc validation DOC Ensures that dcg_score & roc_curve passes numpydoc validation Sep 7, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants