DOC Ensures that fowlkes_mallows_score and entropy passes numpydoc validation #24352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch used to open this PR, was not forked from I will make a push to solve these issues. |
|
Uhm I see that you did the full modules so let me check then. |
glemaitre
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
LGTM @shellyfung I will wait for the CI to complete even if I ran the tests locally.
thanks |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 12, 2022
…it-learn#24352) Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
What does this implement/fix? Explain your changes.
Fixed docstring to allow cluster._supervised docstring to pass numpydoc validation.
Any other comments?