DOC Ensures that sklearn.tree._export.plot_tree passes numpydoc validation #24559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmloyola
reviewed
Oct 2, 2022
There was a problem hiding this comment.
(@mauroantonioserrano and @naomipoclava2021 worked during the SciPy LATAM Sprint)
Try to use English to communicate, both in the PR description and in the commits.
The PR looks good.
I left just one comment.
Co-authored-by: Juan Martin Loyola <[email protected]>
|
LGTM. Thanks @mauroantonioserrano. Merging. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Oct 9, 2022
…ation (scikit-learn#24559) Co-authored-by: Juan Martin Loyola <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
…ation (scikit-learn#24559) Co-authored-by: Juan Martin Loyola <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?