Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Ensure that sklearn.utils.is_scalar_nan passes numpydoc validation #24562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

rjuer
Copy link
Contributor

@rjuer rjuer commented Oct 2, 2022

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

Adds parameter and return value descriptions

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our convention is to use the Python type. While it is passing the numpydoc, we can make the change in the same PR.

@glemaitre
Copy link
Member

I merge the changes since this is a really small change.
I will merge this PR then since it is ready.
Thanks @rjuer

@glemaitre glemaitre merged commit 0c22fa1 into scikit-learn:main Oct 3, 2022
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Oct 9, 2022
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants