-
-
Notifications
You must be signed in to change notification settings - Fork 26k
MAINT Clean deprecation for 1.2: load_boston #24603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Clean deprecation for 1.2: load_boston #24603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeremiedbb
sklearn/datasets/__init__.py
Outdated
The Boston housing prices dataset has an ethical problem. You can refer to | ||
the documentation of this function for further details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the documentation of the function doesn't exist anymore. We need to adapt this message to reflect why it was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! This is a nice use case for __getattr__
.
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
removed the deprecated
datasets.load_boston
function.When deprecating it, it was decided to create a custom import error when trying to import this function to still show the message about ethical issues with this dataset.