DOC Ensures that sklearn.utils.extmath.fast_logdet
passes numpydoc validation
#24605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #21350
Ensures that
sklearn.utils.extmath.fast_logdet
passes numpydoc validation.What does this implement/fix? Explain your changes.
sklearn.utils.extmath.fast_logdet
fromtest_docstrings.py
numpy.linalg.slogdet
.Any other comments?
A limitation of this function as compared to
numpy.linalg.slogdet
is that it cannot broadcast for multiple matrices in a single function call.When we pass a stack of matrices as input it throws a ValueError.
Ex:
I could work on this issue if required.