Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT set plotly min to 5.10 #24629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

ArturoAmorQ
Copy link
Member

Reference Issues/PRs

Follow up of #23740.

What does this implement/fix? Explain your changes.

plotly.express.parallel_coordinates raises a FutureWarning about pandas DataFrame.append method being deprecated for plotly versions <= v5.9.0 (see plot_grid_search_text_feature_extraction.py example).

This PR updates plotly to the latest version, where the issue has been fixed.

Any other comments?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArturoAmorQ ArturoAmorQ added the Quick Review For PRs that are quick to review label Oct 11, 2022
@glemaitre glemaitre merged commit 6c00e94 into scikit-learn:main Oct 13, 2022
@glemaitre
Copy link
Member

Thanks @ArturoAmorQ

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Oct 31, 2022
@ArturoAmorQ ArturoAmorQ deleted the update_plotly branch November 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants