ENH Improve set_output compatibility in ColumnTransformer #24699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Oct 19, 2022
Member
glemaitre
left a comment
There was a problem hiding this comment.
I am fine with the proposed behaviour. I think that this is something that third-party libraries could find useful.
| X_df = pd.DataFrame({"feat1": [1, 2, 3], "feat2": [3, 4, 5]}) | ||
|
|
||
| X_wrapped = _wrap_in_pandas_container(X_df, columns=get_columns) | ||
| assert_array_equal(X_wrapped.columns, X_df.columns) |
Member
There was a problem hiding this comment.
Since the documentation mentioned that raising an error is equivalent to None, I think that we should test the case where we raise an error and we pass something else than a dataframe to check that we return range(X.shape[1])
Member
Author
There was a problem hiding this comment.
Added test in 0fc62e6 (#24699) and adjusted it slightly in 2fb935f (#24699)
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #23734
What does this implement/fix? Explain your changes.
On
main, if the inner transformers does not defineget_feature_names_out, thenColumnTransformerwill error even if all the transformers return a DataFrame. This is becauseColumnTransformer.get_feature_names_outis called to adjust the column names to followverbose_feature_names_out.This PR makes
ColumnTransformermore lenient toward transformers that return DataFrames but does not defineget_feature_names_out. Feature names out are prefixed followingverbose_feature_names_out. The prefixing logic is shared withget_feature_names_outand refactored into a_add_prefix_for_feature_names_outmethod.Any other comments?
I think it is common to have third-party transformers that only expect dataframes and will always return DataFrames regardless of how
set_outputis configured.