DOC remove FutureWarnings from plot_stack_predictors #24918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
ArturoAmorQ
approved these changes
Nov 14, 2022
glemaitre
reviewed
Nov 14, 2022
Comment on lines
78
to
79
| X = X[:600] | ||
| y = y[:600] | ||
| y = y.iloc[:600] |
There was a problem hiding this comment.
We should probably be more explicit here. I am not sure that everyone knows what happens when slicing a dataframe with integers :)
Let's do the following to be extra explicit:
X = X.loc[:, features]
X, y = shuffle(X, y, random_state=0)
X = X.iloc[:600]
y = y.iloc[:600]|
The error in the linter is not linked to this PR. LGTM. Merging |
@glemaitre There was linter error in this PR - there was no whitespace between comma and variable name in: |
|
Thanks. I just pushed a fix in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixes the task ensemble/plot_stack_predictors.html of the issue #24876 .
Any other comments?
This PR fixes the FutureWarning linked to the usage of series[i:j]. The last keyword is replaced by series.iloc[i:j] making the Depreciation Warning go away.