Add link to linkcheck_ignore #25076
Closed
Add link to linkcheck_ignore #25076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the message of this PR to include a short explanation of why the link needs to be added to the list of links excluded from checks? |
Yes, I could. I updated. |
|
Thanks for the PR, the "Linting" CI check is failing, to fix this you need to run It would be great if you put the two github links one after the other in Also for your next PR, please create a feature branch to create a PR, rather than using your |
|
For completeness #25082 (by the same author as this PR) was doing the same and has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is a fix related to the issue #25024.
Add
https://github.com/joblib/threadpoolctl/#setting-the-maximum-size-of-thread-poolstolinkcheck_ignore.Reason why the link needs to be added to the list of links excluded from checks:
The link works fine in a browser but is flagged as broken by make linkcheck tool.