ENH better error message in HGBRT with feature names #25092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
LGTM
For other reviewers, the CI failure is unrelated and is being looked at here: #25091
jeremiedbb
approved these changes
Dec 2, 2022
jeremiedbb
added a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 6, 2022
) Co-authored-by: jeremie du boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to improve the error messages when using the feature names.
In case it's merged in time, I think it might be a good idea to backport to 1.2.X before the release.