-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
FIX Raises informative error in FeatureHasher when a sample is a single string #25094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Raises informative error in FeatureHasher when a sample is a single string #25094
Conversation
|
Since we check only the first element, a list such as |
|
I think I think I'd be ok with just checking the first instance. See if we get more bug reports and then act |
jnothman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a useful improvement.
I'm okay to consider it a bugfix |
That's what we usually do in such cases. |
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reference Issues/PRs
Fixes #13199
What does this implement/fix? Explain your changes.
When
input_type="string",FeatureHasherexpects a list of a list of strings. This PR raises an error if the input is just a list of strings.Any other comments?
I am open to deprecating as suggested in #13199 (comment), but from reading the original issue I think the current behavior is a bug.