MAINT Parameters validation for metrics.roc_curve
#25108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics.roc_curve
|
Thanks for working on this. The change looks reasonable to me. The linting tests that check the formatting of the code are failing. Take a look at step 9 of https://scikit-learn.org/stable/developers/contributing.html#how-to-contribute or the section after that for the tools you need to run to have the formatting fixed automatically. The easiest way is to use pre-commit. |
6 tasks
|
Thanks @betatim, I think I solved it. |
betatim
reviewed
Dec 6, 2022
jeremiedbb
reviewed
Dec 6, 2022
added 2 commits
December 6, 2022 18:50
@jeremiedbb good point, done |
jeremiedbb
approved these changes
Dec 6, 2022
|
Interestingly we broke the documentation CI :) |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Jérémie du Boisberranger <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
Includes parameter validation for metrics.roc_curve
Any other comments?
Test passes pytest -vl sklearn/tests/test_public_functions.py