Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX ignore *args and **kwargs in parameter validation of public functions #25114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 5, 2022
Merged

FIX ignore *args and **kwargs in parameter validation of public functions #25114

merged 6 commits into from
Dec 5, 2022

Conversation

glemaitre
Copy link
Member

closes #25113

Avoid including *args and **kwargs in the parameter validation.
Since the number of arguments is varying, we cannot create a constraint for them.
The idea is to filter them for the moment.

adrinjalali
adrinjalali approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't wanna test this?:D

@glemaitre
Copy link
Member Author

you don't wanna test this?:D

Actually, I should make one validation :)

jeremiedbb
jeremiedbb reviewed Dec 5, 2022
View reviewed changes
glemaitre and others added 3 commits December 5, 2022 15:53
@glemaitre @jeremiedbb
Update sklearn/tests/test_public_functions.py
894c532 
Co-authored-by: Jérémie du Boisberranger <[email protected]>
@glemaitre @jeremiedbb
Update sklearn/model_selection/_split.py
7388fee 
Co-authored-by: Jérémie du Boisberranger <[email protected]>
@glemaitre @jeremiedbb
Update sklearn/model_selection/_split.py
fdb0b15 
Co-authored-by: Jérémie du Boisberranger <[email protected]>
@lesteve lesteve mentioned this pull request Dec 5, 2022
Closed
6 tasks
jeremiedbb
jeremiedbb approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjerphan jjerphan merged commit b01f018 into scikit-learn:main Dec 5, 2022
@jjerphan jjerphan added this to the 1.2.1 milestone Jan 19, 2023
@jjerphan jjerphan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Jan 19, 2023
@jjerphan jjerphan mentioned this pull request Jan 19, 2023
Merged
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@glemaitre @jeremiedbb @jjerphan
FIX ignore *args and **kwargs in parameter validation of public funct…
b223bd3 
…ions (scikit-learn#25114)

Co-authored-by: Jérémie du Boisberranger <[email protected]>
closes scikit-learn#25113
@jjerphan jjerphan mentioned this pull request Jan 20, 2023
Merged
12 tasks
@jjerphan jjerphan modified the milestones: 1.2.1, 1.3 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
No Changelog Needed To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Handling *args and **kwargs in parameter validation framework
4 participants
@glemaitre @adrinjalali @jeremiedbb @jjerphan