FIX Remove spurious UserWarning
#25129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition was not the proper one: it must be a conjuction and not a disjonction. This is rewritten more naturally using a negation.
|
A small regression test could be nice here. |
jeremiedbb
reviewed
Dec 7, 2022
sklearn/metrics/_pairwise_distances_reduction/_radius_neighbors.pyx.tp
Outdated
Show resolved
Hide resolved
thomasjpfan
approved these changes
Dec 7, 2022
sklearn/metrics/_pairwise_distances_reduction/_radius_neighbors.pyx.tp
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas J. Fan <[email protected]>
ArturoAmorQ
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
I confirm that the rendering of the doc no longer raises such spurious warnings. Thanks @jjerphan!
|
Let's see if the auto-merge is going to work ;) |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 7, 2022
Vincent-Maladiere
pushed a commit
to Vincent-Maladiere/scikit-learn
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None, reported IRL by @ArturoAmorQ
What does this implement/fix? Explain your changes.
Currently spurious
UserWarninge.g.:are reported to users.
This is notably the case in example such as this one.
The problem is due to an improper condition.
The condition was not the proper one: it must be a conjuction and not a disjonction.
This is rewritten more naturally using a negation.