Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH KBinsDiscretizer sample_weight support for kmeans strategy - #25257

Merged
TomDLT merged 5 commits into
scikit-learn:mainfrom
glevv:kbd-kmeans-sample-weight
Jan 3, 2023
Merged

ENH KBinsDiscretizer sample_weight support for kmeans strategy#25257
TomDLT merged 5 commits into
scikit-learn:mainfrom
glevv:kbd-kmeans-sample-weight

Conversation

@glevv

@glevv glevv commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #25231

What does this implement/fix? Explain your changes.

Adding support for sample_weight parameter when strategy='kmeans' in KBinsDiscretizer

tests for sample_weight if strategy=kmeans
@glevv
glevv marked this pull request as ready for review December 30, 2022 14:22

@jeremiedbb jeremiedbb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @glevv

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Jan 3, 2023

@TomDLT TomDLT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@TomDLT
TomDLT merged commit cde6d65 into scikit-learn:main Jan 3, 2023
@glevv
glevv deleted the kbd-kmeans-sample-weight branch January 4, 2023 08:10
johnpangas pushed a commit to johnpangas/scikit-learn that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:preprocessing Quick Review For PRs that are quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sample_weight parameter in KBinsDiscretizer with kmeans strategy

3 participants