FIX Handles all numerical DataFrames with check_inverse=True in FunctionTransformer #25274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Jan 2, 2023
Member
|
I don't understand the coverage failure. I check locally and the 2 branches introduced by this PR are indeed covered by the 2 added tests. So let's merge |
jpangas
pushed a commit
to jpangas/scikit-learn
that referenced
this pull request
Jan 4, 2023
…ionTransformer (scikit-learn#25274) Co-authored-by: Jérémie du Boisberranger <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ionTransformer (scikit-learn#25274) Co-authored-by: Jérémie du Boisberranger <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…ionTransformer (scikit-learn#25274) Co-authored-by: Jérémie du Boisberranger <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
…ionTransformer (scikit-learn#25274) Co-authored-by: Jérémie du Boisberranger <[email protected]>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
…ionTransformer (#25274) Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25261
Closes #19905
What does this implement/fix? Explain your changes.
This PR explicitly handles dataframes when validating the input when
check_inverse=True.Any other comments?
This closes in #19905, because it explicity raises an error for DataFrames
FunctionTransformerdoes not know how to validate.