FIX SplineTransformer.get_feature_names_out returns correct names for extrapolations=periodic #25296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extrapolations=periodic
kaqmak
approved these changes
Jan 5, 2023
kaqmak
left a comment
There was a problem hiding this comment.
LGTM, although I find the naming of n_spline confusing. I.e. sometimes it does refer to the shape of self.bsplines (self.bsplines_[0].c.shape[1]) as is seen in the transform method, while sometimes it refers to a modification of it (self.bsplines_[0].c.shape[1]-self.degree) as seen in the fit method.
glemaitre
approved these changes
Jan 5, 2023
Member
glemaitre
left a comment
There was a problem hiding this comment.
I agree with the comment of @kaqmak. Otherwise LGTM.
Thanks @thomasjpfan
ogrisel
approved these changes
Jan 18, 2023
Member
ogrisel
left a comment
There was a problem hiding this comment.
LGTM as well (I trust the tests :).
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
… extrapolations=periodic (scikit-learn#25296) Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
… extrapolations=periodic (scikit-learn#25296) Co-authored-by: Olivier Grisel <[email protected]>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
… extrapolations=periodic (scikit-learn#25296) Co-authored-by: Olivier Grisel <[email protected]>
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
… extrapolations=periodic (#25296) Co-authored-by: Olivier Grisel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #25292
What does this implement/fix? Explain your changes.
This PR fixes
get_feature_names_outby adjustingn_splineswhenextrapolation="periodic".